ci(release): fix verify-fetchable fingerprint error#10
Merged
Conversation
Zig 0.16 requires every build.zig.zon to declare a fingerprint. The
synthetic consumer package that verify-fetchable writes into a temp dir
was missing one, which caused `zig fetch --save` to fail with "missing
top-level 'fingerprint' field" — misattributed in the v0.2.0 release run
because the error points at `build.zig.zon:1:2` without naming the file.
The suggested value (0x1c1c658521dd0fe1) encodes crc32("fetch_test") in
the upper 32 bits + a pinned random id in the lower 32; it is unrelated
to our real package fingerprint in /build.zig.zon.
Also pin `minimum_zig_version` on the consumer so the check fails loudly
if CI ever drifts off 0.16.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fingerprint(andminimum_zig_version) to the syntheticfetch_testbuild.zig.zonthatverify-fetchablewrites at runtime.verify-fetchablewithmissing top-level 'fingerprint' field; suggested value: 0x1c1c658521dd0fe1— that value is forfetch_test, not our real package. Our ownbuild.zig.zonwas never the problem.Test plan
v0.2.0after merge; confirmverify-fetchableis green.🤖 Generated with Claude Code
Greptile Summary
The
verify-fetchablejob now writes a valid Zig 0.16.0build.zig.zonfor the syntheticfetch_testworkspace by including the.fingerprint(0x1c1c658521dd0fe1) and.minimum_zig_versionfields that Zig 0.16.0 requires. The realbuild.zig.zon(fingerprint0xa5fe060596d90b43) was never touched — this is a targeted, correct fix for the CI failure reported in the PR description.Confidence Score: 5/5
Safe to merge — single-file CI fix with no logic changes outside the synthetic test workspace.
The change is narrowly scoped: two fields added to a heredoc that writes a throw-away
build.zig.zon. The fingerprint value matches the value Zig 0.16.0 itself suggested in the error, confirming correctness.No files require special attention.
Important Files Changed
.fingerprintand.minimum_zig_versionto the syntheticfetch_testbuild.zig.zonwritten at runtime by theverify-fetchablejob, fixing the Zig 0.16.0 required-field error that broke the v0.2.0 release pipeline.Reviews (1): Last reviewed commit: "ci(release): add fingerprint to verify-f..." | Re-trigger Greptile