feat(harness): add description field to custom subagent factory#1506
Open
chenlinks wants to merge 2 commits into
Open
feat(harness): add description field to custom subagent factory#1506chenlinks wants to merge 2 commits into
chenlinks wants to merge 2 commits into
Conversation
SubagentFactoryEntry previously held only a name and factory, so the DynamicSubagentsHook exposed the bare name as the subagent description. Names alone often fail to convey a subagent's function, leaving the orchestrator without useful selection context. Add an optional description: a new subagentFactory(name, description, factory) builder overload and a displayDescription() fallback that uses the name when the description is null or blank. The existing two-arg overload is preserved, so callers need no changes. Closes agentscope-ai#1504
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SubagentFactoryEntry previously held only a name and factory, so the DynamicSubagentsHook exposed the bare name as the subagent description. Names alone often fail to convey a subagent's function, leaving the orchestrator without useful selection context.
Add an optional description: a new
subagentFactory(name, description, factory) builder overload and a displayDescription() fallback that uses the name when the description is null or blank. The existing two-arg overload is preserved, so callers need no changes.
Closes #1504
AgentScope-Java Version
[The version of AgentScope-Java you are working on, e.g. 1.0.12, check your pom.xml dependency version or run
mvn dependency:tree | grep agentscope-parent:pom(only mac/linux)]Description
[Please describe the background, purpose, changes made, and how to test this PR]
Checklist
Please check the following items before code is ready to be reviewed.
mvn spotless:applymvn test)