Skip to content

feat(sdk): add out of the box controls - part 1 - #246

Merged
namrataghadi-galileo merged 7 commits into
mainfrom
feature/67101-out-of-box-controls
Aug 11, 2026
Merged

feat(sdk): add out of the box controls - part 1#246
namrataghadi-galileo merged 7 commits into
mainfrom
feature/67101-out-of-box-controls

Conversation

@namrataghadi-galileo

Copy link
Copy Markdown
Contributor

Summary

  • Added Phase 1 out-of-box controls bootstrap tooling so startup can safely seed controls later without duplicating rows or blocking pod startup.
  • Added evaluator gating, namespace-aware seeding, initial version creation, idempotency, duplicate-name race handling, and fail-open lifespan integration.

Scope

  • User-facing/API changes: None.
  • Internal changes: New agent_control_server.bootstrap module, startup seeding hook, and bootstrap tests.
  • Out of scope: Actual OOTB control definitions, Phase 2 regex/json/list templates, and Phase 3 Luna metadata seeding.

Risk and Rollout

  • Risk level: low
  • Rollback plan: Remove the lifespan call to seed_out_of_box_controls and/or revert the bootstrap module and related tests.

Testing

  • Added or updated automated tests
  • Ran make check (not run because uv dependency resolution hit private index 401s)
  • Manually verified behavior via targeted tests, server lint, and server mypy using the existing .venv

Checklist

  • Linked issue/spec (Phase 1 from OOTB controls technical spec)
  • Updated docs/examples for user-facing changes: N/A, no user-facing changes
  • Included any required follow-up tasks in .md format: Phase 2 follow-up not yet added as a separate .md file

@codecov

codecov Bot commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.67442% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...nt_control_server/bootstrap/out_of_box_controls.py 98.16% 2 Missing ⚠️
server/src/agent_control_server/main.py 90.90% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Comment thread server/src/agent_control_server/bootstrap/out_of_box_controls.py
Comment thread server/src/agent_control_server/main.py Outdated
@namrataghadi-galileo namrataghadi-galileo changed the title feat(sdk): add out of hte box controls feat(sdk): add out of the box controls - part 1 Jul 30, 2026
Comment thread server/src/agent_control_server/bootstrap/out_of_box_controls.py Outdated
Comment thread server/alembic/versions/f3a1c8d7e2b4_out_of_box_control_seed_identity.py Outdated

@abhinav-galileo abhinav-galileo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to address this - #246 (comment)

@namrataghadi-galileo
namrataghadi-galileo enabled auto-merge (squash) August 11, 2026 16:49
@namrataghadi-galileo
namrataghadi-galileo merged commit 45dea6d into main Aug 11, 2026
6 checks passed
@namrataghadi-galileo
namrataghadi-galileo deleted the feature/67101-out-of-box-controls branch August 11, 2026 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants