docs(schema): rewrite generator-unfriendly unions#7
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR adds a new validation test fixture for a tool call marked as truncated with missing arguments. It includes the fixture data file, the expected validation results and diagnostics in the manifest, and documentation of the scenario in the conformance manifest README. ChangesValidation fixture for truncated tool call
🎯 1 (Trivial) | ⏱️ ~4 minutes
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Running ultrareview automatically — This PR rewrites core schema shapes (tool_call, tool_call_aborted, capability_change) into generator-friendly direct unions and adds a canonical recursive jsonValue type, affecting 5,073 lines across schema definitions and validation fixtures — a schema-level change with broad blast radius.... I'll post findings when complete. |
|
Ready to review this PR? Stage has broken it down into 7 individual chapters for you: Chapters generated by Stage for commit bba72c2 on Jun 13, 2026 10:29am UTC. |
Pull Request
Summary
jsonValuefor explicit open-value sites.tool_call,tool_call_aborted, andcapability_changeschema shapes into generator-friendly direct unions.tool_call.truncated: truewithoutargs_size.Related Issue
Public Impact
Impact description:
Verification
jq empty schema/*.json fixtures/validation/*.jsonpassed.mise exec -- ajv compile --spec=draft2020 --strict=false --validate-formats=false -s schema/draft.jsonpassed.mise exec -- ajv compile --spec=draft2020 --strict=false --validate-formats=false -s schema/v0.1.0.jsonpassed.node scripts/check-schema-descriptions.mjspassed.jsonValueextension value.mise run checkpassed with sandbox cache warnings from mise.cmp -s schema/draft.json schema/v0.1.0.jsonpassed.Reviewer Notes