Skip to content

ci(spec): remove redundant fixture check#5

Merged
somus merged 1 commit into
mainfrom
somus/remove-redundant-fixture-check
Jun 12, 2026
Merged

ci(spec): remove redundant fixture check#5
somus merged 1 commit into
mainfrom
somus/remove-redundant-fixture-check

Conversation

@somus

@somus somus commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Pull Request

Summary

  • Remove the standalone check:fixtures task.
  • Let check:conformance remain the single fixture manifest integrity gate.
  • Keep JSON syntax, schema, conformance, lint, and Actions checks in mise run check.

Related Issue

  • Follow-up to ATF-14

Public Impact

  • No public contract change
  • Spec or schema change
  • Public package API change
  • CLI behavior change
  • Public URL or docs behavior change

Impact description:

  • CI/tooling cleanup only. Public spec, schema, fixture contents, and docs remain unchanged.

Verification

  • MISE_DATA_DIR=/private/tmp/mise-data-agent-trail MISE_CACHE_DIR=/private/tmp/mise-cache-agent-trail npm_config_cache=/private/tmp/npm-cache-agent-trail mise run check - passed

Reviewer Notes

  • scripts/check-conformance.mjs already checks duplicate manifest paths, missing/extra fixture paths, and sorted manifest order, so the shell check:fixtures gate was redundant.

Open in Stage

Review in cubic

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@somus, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 45 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 4906c16d-6661-46ec-bd29-0de52203c950

📥 Commits

Reviewing files that changed from the base of the PR and between f211f28 and 8ac66fa.

📒 Files selected for processing (1)
  • mise.toml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch somus/remove-redundant-fixture-check

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@stage-review

stage-review Bot commented Jun 12, 2026

Copy link
Copy Markdown

Ready to review this PR? Stage has broken it down into 1 individual chapter for you:

Title
1 Consolidate fixture integrity checks
Open in Stage

Chapters generated by Stage for commit 8ac66fa on Jun 12, 2026 7:29pm UTC.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.
Architecture diagram
sequenceDiagram
    participant Dev as Developer
    participant CI as CI Pipeline
    participant Mise as Mise Task Runner
    participant JSON as check:json
    participant Schema as check:schema
    participant Conform as check:conformance
    participant Fixtures as Fixture Files

    Note over Dev,Fixtures: CI Check Flow (current state)

    Dev->>CI: Push / PR trigger
    CI->>Mise: mise run check
    Mise->>Mise: Resolve dependency chain

    Mise->>JSON: depends
    JSON->>JSON: Validate JSON/JSONL syntax
    JSON-->>Mise: Success

    Mise->>Schema: depends
    Schema->>Schema: Compile & validate manifest schema
    Schema-->>Mise: Success

    Mise->>Conform: depends
    Conform->>Fixtures: Read fixture manifest & .trail.jsonl files
    Conform->>Conform: Check duplicate manifest paths
    Conform->>Conform: Check missing/extra fixture paths
    Conform->>Conform: Verify sorted manifest order
    Conform-->>Mise: Success

    Mise-->>CI: All checks passed
    CI-->>Dev: Pipeline green
Loading

Shadow auto-approve: would auto-approve. This PR removes a redundant shell-based fixture check that is already covered by the conformance check script. The change is limited to CI/tooling config and has no impact on business logic, data, or public contracts.

Re-trigger cubic

@somus somus merged commit 1255aa2 into main Jun 12, 2026
3 checks passed
@somus somus deleted the somus/remove-redundant-fixture-check branch June 13, 2026 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant