Skip to content

ci(spec): add repository validation checks#4

Merged
somus merged 1 commit into
mainfrom
somus/atf-14-ci-validation
Jun 12, 2026
Merged

ci(spec): add repository validation checks#4
somus merged 1 commit into
mainfrom
somus/atf-14-ci-validation

Conversation

@somus

@somus somus commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Pull Request

Summary

  • Add pinned validation tools for JSON syntax and AJV schema checks.
  • Replace placeholder test task with JSON, schema, fixture manifest integrity, and conformance metadata gates.
  • Add spec-only conformance checks for manifest ordering, fixture coverage, portable diagnostic registry drift, and generated fixture README freshness.
  • Keep existing GitHub Actions validation in the main check flow.

Related Issue

  • Closes ATF-14

Public Impact

  • No public contract change
  • Spec or schema change
  • Public package API change
  • CLI behavior change
  • Public URL or docs behavior change

Impact description:

  • CI/tooling only. Public spec, schema, and fixture contents remain unchanged. Fixture README generator command text now points to the spec repo check task.

Verification

  • MISE_DATA_DIR=/private/tmp/mise-data-agent-trail MISE_CACHE_DIR=/private/tmp/mise-cache-agent-trail npm_config_cache=/private/tmp/npm-cache-agent-trail mise run check - passed
  • Temporary malformed JSONL negative check failed as expected.
  • Temporary unlisted fixture negative check failed as expected.
  • Temporary unsorted manifest negative check failed as expected.
  • Temporary stale fixture README negative check failed as expected.
  • Temporary portable diagnostic registry drift negative check failed as expected.

Reviewer Notes

  • AJV runs with --validate-formats=false to avoid adding ajv-formats solely for schema meta-checking date-time annotations.
  • Semantic fixture validation and hash-vector oracle checks remain planned for SDK/CLI work under ATF-20, ATF-26, and ATF-34.

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@somus, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 10 minutes and 41 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 52038fff-4552-4e46-b320-fea8f531dcbe

📥 Commits

Reviewing files that changed from the base of the PR and between 87c9a66 and 5121a20.

📒 Files selected for processing (3)
  • fixtures/validation/README.md
  • mise.toml
  • scripts/check-conformance.mjs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch somus/atf-14-ci-validation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@stage-review

stage-review Bot commented Jun 12, 2026

Copy link
Copy Markdown

Ready to review this PR? Stage has broken it down into 3 individual chapters for you:

Title
1 Add validation tools to environment configuration
2 Implement conformance check script
3 Configure validation tasks and update documentation
Open in Stage

Chapters generated by Stage for commit 5121a20 on Jun 12, 2026 7:19pm UTC.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.
Architecture diagram
sequenceDiagram
    participant Dev as Developer
    participant CI as GitHub Actions CI
    participant Mise as mise (task runner)
    participant Tools as CLI Tools (jq,ajv)
    participant Schemas as Schema Files
    participant Fixtures as Fixture Files
    participant Manifest as Manifest JSON

    Note over Dev,CI: CI Pipeline Validation Flow

    Dev->>CI: Push code changes
    CI->>Mise: mise run check
    Mise->>Mise: Resolve tasks in dependency order

    alt check:json phase
        Mise->>Tools: jq empty schema/*.json
        Tools-->>Mise: JSON syntax OK
        Mise->>Tools: jq empty fixtures/validation/*.json
        Tools-->>Mise: JSON syntax OK
        Mise->>Tools: jq empty *.trail.jsonl (one per file)
        Tools-->>Mise: JSONL syntax OK
    end

    alt check:schema phase
        Mise->>Tools: ajv compile schema/draft.json
        Schemas->>Tools: Draft schema
        Tools-->>Mise: Schema compiles
        Mise->>Tools: ajv compile schema/v0.1.0.json
        Schemas->>Tools: Version schema
        Tools-->>Mise: Schema compiles
        Mise->>Tools: ajv compile manifest.schema.json
        Schemas->>Tools: Manifest schema
        Tools-->>Mise: Schema compiles
        Mise->>Tools: ajv validate manifest.json against manifest.schema.json
        Manifest->>Tools: Manifest content
        Tools-->>Mise: Validation passes
    end

    alt check:fixtures phase
        Mise->>Tools: jq extract fixture paths from manifest.json
        Manifest-->>Tools: fixture list paths
        Mise->>Mise: Sort manifest paths (in memory)
        Mise->>Mise: Find all .trail.jsonl files on disk
        Mise->>Mise: Sort disk paths
        Mise->>Mise: Check for duplicate paths in manifest
        Note over Mise: If duplicate found → fail with exit 1
        Mise->>Mise: diff manifest paths vs disk paths
        Note over Mise: If mismatch found → fail with exit 1
    end

    Mise-->>CI: All checks pass / fail exit code
    CI-->>Dev: Build status result
Loading

Shadow auto-approve: would auto-approve. This is a CI/tooling-only change that adds validation tools (jq, ajv-cli) and new tasks for JSON syntax, schema compilation, and fixture manifest integrity checks. No business logic, public API, schema definitions, or production code are modified.

Re-trigger cubic

@somus somus force-pushed the somus/atf-14-ci-validation branch from c38dc0f to 5121a20 Compare June 12, 2026 19:18
@somus somus merged commit f211f28 into main Jun 12, 2026
2 checks passed
@somus somus deleted the somus/atf-14-ci-validation branch June 13, 2026 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant