fix: reject credentials missing required _sd_alg claim#8
Open
hydeta wants to merge 1 commit into
Open
Conversation
Signed-off-by: Timothy Hyde <tim@baselayer.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
_sd_algclaim is REQUIRED on L1, L2, and L3 credentials per the credential format spec (L1 §3.3, L2 §4.3, L3 §5.3) and RFC 9901 §5.1.1. The verification chain currently only checks that_sd_algequals"sha-256"when present, silently accepting credentials that omit the claim entirely.This changes the three
_sd_algchecks inverify_chainfrom:to:
so that a missing _sd_alg is now treated as a verification failure rather than a pass.
All issuance functions already include _sd_alg: "sha-256" in every credential they produce, so this only affects externally constructed or malformed credentials reaching the verifier.
Changes
Test plan