Skip to content

Adopt reverse notation for pattern_name #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tboulogne wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Adopt reverse notation for pattern_name #17

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f02660
pattern_name as reverse
tboulogne Nov 9, 2019
5882f72
adopt reverse notation
tboulogne Nov 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions navutils/menu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,11 +109,10 @@ def get_url(self, **kwargs):
:return: The target URL of the node, after reversing (if needed)
"""
if self.pattern_name:
expected_kwargs = {
key: value for key, value in kwargs.items()
if key in self.reverse_kwargs
}
return reverse(self.pattern_name, kwargs=expected_kwargs)
args = False
if len(self.pattern_name)>1:
args = self.pattern_name[1]
return reverse(self.pattern_name[0], args=args)
return self.url

def add(self, node):
Expand Down