Skip to content

fix kwargs for reverse pattern_name - #16

Open
tboulogne wants to merge 1 commit into
agateblue:developfrom
tboulogne:patch-1
Open

fix kwargs for reverse pattern_name#16
tboulogne wants to merge 1 commit into
agateblue:developfrom
tboulogne:patch-1

Conversation

@tboulogne

Copy link
Copy Markdown

No description provided.

@agateblue

Copy link
Copy Markdown
Owner

Hi @tboulogne, I'd like to merge this, but I'm lacking some context. Can you please elaborate on the problem this solves? Thank you!

@tboulogne

Copy link
Copy Markdown
Author

Hi @EliotBerriot,

Without self, kwargs is empty, and pattern with args never works.

Hope it help.

regards

@agateblue

Copy link
Copy Markdown
Owner

Isn't it possible to provide the kwargs when calling get_url ?

@agateblue

Copy link
Copy Markdown
Owner

E.g like that:

node = menu.Node('test', 'Test', pattern_name='category', reverse_kwargs=['slug'])
url = node.get_url(slug='test')

@tboulogne

Copy link
Copy Markdown
Author

A best approach could be to use reverse syntax :

reverse('category', args=['slug'])

In you case :

node = menu.Node('test', 'Test', pattern_name=('category', ['slug'])

More logical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants