Skip to content

build(deps): bump codecov/codecov-action from 6 to 7 #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dependabot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build(deps): bump codecov/codecov-action from 6 to 7 #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci-build-test.yml
View file
Open in desktop

@devin-ai-integration devin-ai-integration Bot Jun 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Operator precedence issue in create-pr job condition (pre-existing)

The if condition at lines 274-276 reads:

github.event_name == 'push' && 
startsWith(github.ref, 'refs/heads/feature/') || startsWith(github.ref, 'refs/heads/bug/') || startsWith(github.ref, 'refs/heads/hotfix/')

Due to && binding more tightly than ||, this evaluates as (push && feature/) || bug/ || hotfix/, meaning the job would trigger for bug/ or hotfix/ branches on any event type (including pull_request), not just push events. The likely intent was push && (feature/ || bug/ || hotfix/). This is pre-existing and unrelated to this PR's change.

(Refers to lines 274-276)

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ jobs:
fi

- name: 📊 Upload coverage reports to Codecov
uses: codecov/codecov-action@v6
uses: codecov/codecov-action@v7
with:
files: TestResults/CoverageReport/Summary.xml
flags: unittests
Comment on lines 228 to 234

@devin-ai-integration devin-ai-integration Bot Jun 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 coverage-reports job will never find TestResults directory

The coverage-reports job (line 197) runs as a separate GitHub Actions job from build-qrcoder and build-windows. Since each job runs in an isolated runner, the TestResults/ directory produced by the build jobs is not available here. The if [ -d "TestResults" ] check at line 224 will always be false, meaning no coverage report is ever generated and the Codecov upload at line 231 will always attempt to upload a nonexistent file. This is a pre-existing issue unrelated to the v6→v7 bump, but it means the codecov action change is essentially a no-op since there's nothing to upload regardless of version. The fix would require downloading test result artifacts from the build jobs before generating reports.

(Refers to lines 221-237)

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Expand Down
Loading