Skip to content

docs(readme): fix namespace references#54

Open
nick-lay wants to merge 1 commit into
afonsoft:mainfrom
nick-lay:main
Open

docs(readme): fix namespace references#54
nick-lay wants to merge 1 commit into
afonsoft:mainfrom
nick-lay:main

Conversation

@nick-lay

@nick-lay nick-lay commented May 29, 2026

Copy link
Copy Markdown

Update using statements in code examples to use the correct namespaces


Open in Devin Review

Update using statements in code examples to use the correct namespaces
@sonarqubecloud

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 potential issues.

Open in Devin Review

Comment thread README.md
Comment on lines +116 to +117
using QRCoder.Core.Generators;
using QRCoder.Core.Renderers;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Bilingual docs not updated alongside README

The PR updates import statements in README.md code examples from using QRCoder.Core; / using SkiaSharp; to using QRCoder.Core.Generators; / using QRCoder.Core.Renderers;. However, the equivalent code examples in docs/en-US/usage-guide.md:54-55 and docs/pt-BR/guia-de-uso.md:54-55 still use the old imports (using QRCoder.Core; and using SkiaSharp;). The AGENTS.md DO rules include "Documentação bilíngue (pt-BR + en-US)", and these docs now show different (and likely incorrect) import statements compared to the README. This pre-existing inconsistency is now amplified by the PR — the README is correct while the docs remain stale.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Comment thread README.md
using QRCoder.Core;
using SkiaSharp;
using QRCoder.Core.Generators;
using QRCoder.Core.Renderers;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Info: Removal of using SkiaSharp; is safe due to var usage

The Quick Start example previously had using SkiaSharp; which was replaced by using QRCoder.Core.Renderers;. This is safe because the code example uses var for all SkiaSharp types (e.g., using var bitmap = qrCode.GetGraphic(10); where the return type is SKBitmap). No SkiaSharp type names are referenced explicitly anywhere in the README code examples. If a user wanted to extend these examples with explicit SkiaSharp types (like SKEncodedImageFormat), they would need to add using SkiaSharp; themselves — but the examples as written are self-consistent.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant