build(deps): bump codecov/codecov-action from 6 to 7#58
Conversation
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 6 to 7. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v6...v7) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
🚩 Operator precedence issue in create-pr job condition (pre-existing)
The if condition at lines 274-276 reads:
github.event_name == 'push' &&
startsWith(github.ref, 'refs/heads/feature/') || startsWith(github.ref, 'refs/heads/bug/') || startsWith(github.ref, 'refs/heads/hotfix/')
Due to && binding more tightly than ||, this evaluates as (push && feature/) || bug/ || hotfix/, meaning the job would trigger for bug/ or hotfix/ branches on any event type (including pull_request), not just push events. The likely intent was push && (feature/ || bug/ || hotfix/). This is pre-existing and unrelated to this PR's change.
(Refers to lines 274-276)
Was this helpful? React with 👍 or 👎 to provide feedback.
| fi | ||
|
|
||
| - name: 📊 Upload coverage reports to Codecov | ||
| uses: codecov/codecov-action@v6 | ||
| uses: codecov/codecov-action@v7 | ||
| with: | ||
| files: TestResults/CoverageReport/Summary.xml | ||
| flags: unittests |
There was a problem hiding this comment.
🚩 coverage-reports job will never find TestResults directory
The coverage-reports job (line 197) runs as a separate GitHub Actions job from build-qrcoder and build-windows. Since each job runs in an isolated runner, the TestResults/ directory produced by the build jobs is not available here. The if [ -d "TestResults" ] check at line 224 will always be false, meaning no coverage report is ever generated and the Codecov upload at line 231 will always attempt to upload a nonexistent file. This is a pre-existing issue unrelated to the v6→v7 bump, but it means the codecov action change is essentially a no-op since there's nothing to upload regardless of version. The fix would require downloading test result artifacts from the build jobs before generating reports.
(Refers to lines 221-237)
Was this helpful? React with 👍 or 👎 to provide feedback.
Bumps codecov/codecov-action from 6 to 7.
Release notes
Sourced from codecov/codecov-action's releases.
Changelog
Sourced from codecov/codecov-action's changelog.
... (truncated)
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)