fix(bridge): main build break — dspEngineSnapshot uses removed AudioEngine bnr* API#3931
Merged
Conversation
… bnr* API main does not compile: AutomationServer.cpp's dspEngineSnapshot() (added in #3920) calls AudioEngine::bnrEnabled()/bnrIntensity()/bnrAddress()/ bnrConnected(), but #3902 removed the old container-BNR API from AudioEngine when it replaced the Maxine NIM container with the in-process AFX denoiser. #3920 was CI-green against a pre-#3902 base, so the semantic break slipped through on merge — every platform's build is now red (the failing TU is the first to reference these symbols). - BNR enabled: a->bnrEnabled() -> a->nvAfxEnabled() (always present), and the availability guard HAVE_BNR -> HAVE_NVIDIA_AFX (HAVE_BNR is no longer defined). - BNR tuning: the in-process AFX has no container, so address/connected are gone; report the persisted NvidiaBnrSettings::intensity() instead. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔴
maindoes not compileAutomationServer.cpp::dspEngineSnapshot()(added in #3920) callsAudioEngine::bnrEnabled()/bnrIntensity()/bnrAddress()/bnrConnected(), but #3902 removed those when it replaced the containerized Maxine-NIM BNR with the in-process AFX denoiser (AudioEnginenow exposesnvAfxEnabled()etc.).These are platform-independent member errors, so every build is red. #3920 was CI-green against a pre-#3902 base, so the semantic conflict slipped through on merge (no re-CI of the merged result).
Fix
a->bnrEnabled()→a->nvAfxEnabled()(always present, even on non-AFX builds), and the availability guardHAVE_BNR→HAVE_NVIDIA_AFX(HAVE_BNRis no longer defined anywhere).address/connectedare dropped from thebnrtuning; report the persistedNvidiaBnrSettings::intensity()instead.One file, no behavior change beyond the snapshot's BNR fields. All other
bnr*references in the tree were checked — these four were the only stale ones.🤖 Generated with Claude Code