stone_script + boulder: Move eval_to_string() to context

[joebonrichie]

This ensures any prefix actions coming from %scriptBase are picked up by the evaluator.

Previously, builddeps from macros specified in environment were not added for evaluation.

[joebonrichie]

@lumi-me-not okay?

[hphilm]

llvm-build.log seems to fix the issue for me I see with llvm and macros in environment

[lumi-me-not]

I was wondering whether it would be better to have a method that returns both the output and the deps, so the deps can then be merged in. But this solution works as well, and might be better.

Maybe also worth thinking about whether we would want eval_to_string on both lib.rs and context.rs.

But anyways, LGTM. :)

[ermo]

I was wondering whether it would be better to have a method that returns both the output and the deps, so the deps can then be merged in. But this solution works as well, and might be better.

Maybe also worth thinking about whether we would want eval_to_string on both lib.rs and context.rs.

But anyways, LGTM. :)

Keep us posted.

Will merge this as-is for now so the related llvm regression gets fixed.

Then we have more time/less pressure when considering your suggestion.