crates/triggers: Support argument expansion with :all/:each - #842
Draft
joebonrichie wants to merge 1 commit into
Draft
crates/triggers: Support argument expansion with :all/:each#842joebonrichie wants to merge 1 commit into
joebonrichie wants to merge 1 commit into
Conversation
Contributor
Author
|
Alternative to #701, we get practically the same performance uplift with the |
Currently, trigger handlers execute once per matched path, this can be slow for trigger handlerss which support processing multiple args. Introduce argument expansion which allows triggers to batch arguments - $(var) / $(var:each) - Execute handler per match - $(var:all) - Execute handler against batched matches e.g. instead of systemctl preset foo.service systemctl preset bar.service systemctl preset baz.service Do: systemctl preset foo.service bar.service baz.service
joebonrichie
force-pushed
the
coalesced-triggers-seq
branch
from
August 4, 2026 13:50
83f4b5e to
9f0996b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, trigger handlers execute once per matched path, this can be slow for trigger handlerss which support processing multiple args.
Introduce argument expansion which allows triggers to batch arguments
e.g. instead of
systemctl preset foo.service
systemctl preset bar.service
systemctl preset baz.service
Do:
systemctl preset foo.service bar.service baz.service