feat: Add SQL-on-FHIR benchmark runner as a dedicated module#2640
Merged
Conversation
Introduce the sof-benchmark module: a runner for the implementation-agnostic SQL-on-FHIR performance benchmark executed over the Pathling engine, with parallel Java and Python implementations. The runner locates a benchmark's materialized dataset manifest-first, separates the FHIR load/encode phase from the timed execute+extract region, times a full write of each case's result, guards output row counts against expectCount, and emits a schema-valid benchmark-report.json. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
piotrszul
force-pushed
the
spike/benchmark_initial
branch
from
985734b to
2829285
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a runner for the implementation-agnostic SQL-on-FHIR performance benchmark (from the
sql-on-fhirsubmodule), executed over the Pathling engine. This lets Pathling act as a second, strongly-typed JVM/Spark implementation that stress-tests the benchmark spec.The runner lives in a dedicated
sof-benchmarkmodule, separate from the JMHbenchmarkmodule — the two share no code, so co-locating them only forced one module to carry the other's dependencies and a single shaded main class. The JMHbenchmarkmodule is left byte-identical to its prior state.What's included
sof-benchmarkmodule (child of the rootpom.xml):library-runtime+spark-sql+jackson-databind, shaded withSofBenchmarkRunneras itsmainClass(runs viajava -jar).au.csiro.pathling.sof.benchmark): manifest-first data location, load phase measured separately from the timed execute+extract region, output row-count correctness guard (ok/count_mismatch), schema-validbenchmark-report.json.sof-benchmark/python/sof_runner.py): mirrors the Java runner over thepathlingpackage usingclick(matching the Pathling Python CLI), isolating language-binding overhead.CONTRIBUTING.mdmodule list + diagram, PythonREADME.md.add-sof-benchmark-runnerarchived; its spec promoted toopenspec/specs/sof-benchmark-runner/.Verification
sof-benchmarkproduces a runnable shaded jar.benchmark-report.schema.json.condition flat → 6219,observation components → 4794), differing only inimplementation.name.🤖 Generated with Claude Code