MWPW-193755 country param#6237
Open
vhargrave wants to merge 5 commits into
Open
Conversation
getCountry() only read ?akamaiLocale= for geo simulation, so ?country=sg did not resolve a lingo locale the way ?akamaiLocale=sg did. Merch/MEP already follow country > akamaiLocale > cookie > geo via computeDetectedMarketCountry; bring lingo's getCountry() into parity. Extract the param-precedence into an exported pure helper getCountryFromParams (mirroring computeDetectedMarketCountry, which is exported for the same reason: PAGE_URL is frozen at module load and the inline path was untestable). getCountry now composes it with the existing sessionStorage + geo fallback, preserving behaviour when country is absent/invalid. Resolves: MWPW-193755 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
getCountry() only read ?akamaiLocale= for geo simulation, so ?country=sg did not resolve a lingo locale the way ?akamaiLocale=sg did. Merch/MEP already follow country > akamaiLocale > cookie > geo via computeDetectedMarketCountry; bring lingo's getCountry() into parity. Extract the param-precedence into an exported pure helper getCountryFromParams (mirroring computeDetectedMarketCountry, which is exported for the same reason: PAGE_URL is frozen at module load and the inline path was untestable). getCountry now composes it with the existing sessionStorage + geo fallback, preserving behaviour when country is absent/invalid. Resolves: MWPW-193755 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…argrave/country-param # Conflicts: # libs/utils/utils.js # test/utils/utils.test.js
…argrave/country-param # Conflicts: # libs/utils/utils.js # test/utils/utils.test.js
…argrave/country-param # Conflicts: # test/utils/utils.test.js
Contributor
vhargrave
requested review from
a team,
markpadbe,
nishantka,
sonawanesnehal3 and
sukamat
zagi25
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow for country param to be used as default now instead of both it and akamaiLocale.
Resolves: MWPW-193755
Test URLs:
Steps to test: