VULN-35559 Fix XSS via URI fragment in Marketo configurator#6225
Open
jsandland wants to merge 2 commits into
Open
VULN-35559 Fix XSS via URI fragment in Marketo configurator#6225jsandland wants to merge 2 commits into
jsandland wants to merge 2 commits into
Conversation
Sanitize all string values loaded from the URL hash in getHashConfig() to strip HTML tags before they enter state or localStorage, preventing injection of event-handler payloads (e.g. onerror, onload) via form.cta.override and form.success.content into window.mcz_marketoForm_pref.
Contributor
Contributor
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
mokimo
approved these changes
Jun 25, 2026
Setting innerHTML executes event handlers (onerror, onload) during sanitization itself. DOMParser parses HTML in an inert context where event handlers do not fire.
Brandon32
approved these changes
Jun 25, 2026
Contributor
|
Reminder to set the |
overmyheadandbody
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getHashConfig()before they enter state or localStorageel.innerHTML = value; return el.textContent) to strip tags and event handlersform.cta.overrideandform.success.contentXSS payloads from reachingwindow.mcz_marketoForm_pref, which Marketo'sforms2.min.jsinjects as raw HTMLResolves: VULN-35559
Attack vector (fixed)
A crafted URL fragment containing JSON with form.cta.override:
"><img src=x onerror=eval(top.name)>caused Marketo's external JS to inject the payload as raw HTML, executing arbitrary JS in the milo.adobe.com origin. The attack used window.name to carry an unbounded exfil payload across the navigation, exfiltrating the victim's Adobe IMS access token (bearer token valid for API calls against Adobe IMS), full name, email, account details, and all cookies from adobe.com. A valid access token allows the attacker to impersonate the victim against Adobe APIs for the duration of the token's validity, which is effectively full account takeover for any signed-in Adobe user who visits the crafted URL.How to validate
Prod (unfixed):
Feature Branch (fixed):
5. Update the delivery page POC URL in workbench to point to https://xss-attack--milo--adobecom.aem.page/tools/marketo?preview=1 keeping the hash from the PoC URL in VULN-35559 unchanged
6. Visit the httpworkbench hostname / delivery page again
7. Check your httpworkbench instance -- no POST is received, only the initial GET from the delivery page load
Test plan
sanitizeConfigValueandsanitizeHashConfigcovering the reported payload, svg/onload variant, plain text preservation, and non-string passthroughhttps://xss-attack--milo--adobecom.aem.page/tools/marketowith full PoC hash -- exfil POST no longer fires