MWPW-195996: adds new icon and product name option#6213
Open
cmiqueo wants to merge 35 commits into
Open
Conversation
* Adds logic for the webClientVersion and susi success logging * c2 changes * tabindexes
* Safari sometimes gets the wrong window height * Removing modal height update * Removing all the resize logic * Changes for c2
Contributor
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
Commits
|
Contributor
|
This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getProductshelper)Jira Ticket
Resolves: MWPW-195996
Changes
libs/blocks/caas-config/caas-config.jsflex-cardtocardStyleoptions plusflexCardImageOptions,flexCardTextAlign, andflexCardTextSizeoption mapsflexCardOptionsandcustomCardOptionsnested panels conditionally on the selected card stylecustomCardtext input out of the always-on list into the conditional Custom Card panelproductNameto the details-text options; minor label/ordering/quote cleanuplibs/blocks/caas-config/caas-config.css.blade-card-options > divand.caas-config .nestedrules.blade-card-options,.flex-card-options, and.nested(indented dark rounded panel, monospace text inputs)libs/blocks/caas/utils.jsgetProducts()helper (returns mnemonics tags, lana-logs on failure)flexCardconfig block ingetConfigwhen a flex-card option deviates from defaultsproductswhendetailsTextOption === 'productName'and include in configflexCardTextAlign,flexCardTextSize, hide toggles,flexCardImageOptions) todefaultStateTest plan
productsare fetched and included in the config, and that a fetch failure degrades gracefully (returns[], logs via lana)ScreenShot
Test URLs: