[SR]MWPW-197617: split-aside-grid RTL and a11y#6204
Conversation
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
zagi25
changed the title
zagi25
force-pushed
the
split-aside-grid-rtl
branch
from
6dcb05e to
94ff469
Compare
overmyheadandbody
left a comment
overmyheadandbody
left a comment
There was a problem hiding this comment.
Just a few nits
| @@ -413,19 +428,66 @@ | |||
| } | |||
|
|
|||
| :root:has(meta[name="foundation"][content="c2"]) { | |||
There was a problem hiding this comment.
Since this is a C2 block, why is this check needed?
| oldFront.style.transition = `transform ${FLY_MS}ms ease-out`; | ||
| oldFront.style.transform = `translateX(${-width}px) rotate(-25deg)`; | ||
| oldFront.style.transform = `translateX(${negateSwipe * -width}px) rotate(${negateSwipe * -25}deg)`; |
There was a problem hiding this comment.
I'm not sure if it was this block where I asked in the past, but: could we set some custom properties and let CSS read and apply them? Just to keep styling in CSS and logic in JS to understand where effects come from. Same applies to logic a bit lower in the file
There was a problem hiding this comment.
I would need to dive more into this. There is a ticket for tech debt (I added this comment also).
|
Reminder to set the |
NadiiaSokolova
left a comment
NadiiaSokolova
left a comment
There was a problem hiding this comment.
Verified. Ready for Stage.
Testing details MWPW-197617, MWPW-198149
NadiiaSokolova
temporarily deployed
to
milo_pr_merge
GitHub Actions
Inactive
4 participants
split-aside-gridResolves: MWPW-197617, MWPW-198149
Test URLs LTR:
Test URLs RTL: