docs(adr-002): align Preflight entity design with Ekrem alignment decisions#2461
Merged
Conversation
…isions - Add asyncJobId FK field (1-to-1 with AsyncJob) to entity schema - Document creation flow: AsyncJob first, then Preflight with asyncJobId - Remove (indexed) from url field; composite index deferred, in-memory filter sufficient given 7-day TTL bounds per-site volume - Clarify endpoint coexistence: /preflight/beta/jobs is removed (replaced), /preflight/jobs is the only legacy endpoint that continues in parallel - Replace open alignment note with confirmed decisions from SITES-44675 - Clarify TTL: verify column name in mysticat-data-service before migration Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
updatedAt is redundant in the list view — status already communicates the current state, and timing detail (startedAt, endedAt) belongs in the single-resource GET response where the full picture is relevant. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
This PR will trigger no release when merged. |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
GeezerPelletier
temporarily deployed
to
dev-branches
GitHub Actions
Inactive
bhellema
approved these changes
May 21, 2026
GeezerPelletier
temporarily deployed
to
dev-branches
GitHub Actions
Inactive
Member
|
🎉 This PR is included in version 1.511.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates ADR-002 to reflect decisions from the SITES-44675 alignment session with @ekdogan. The ADR was previously marked as pending that alignment — this PR closes it out.
Changes to the Data Model section:
asyncJobIdfield added to the entity schema — makes the 1-to-1 FK relationship toAsyncJobexplicit; field is never exposed to API consumersAsyncJobfirst, receivesasyncJobId, then createsPreflightwith that FK; ordering ensures the execution primitive exists before the domain record that references iturlindex annotation removed —(indexed)onurlwas inconsistent with the collection method already specifying in-memory filtering; composite(site_id, url)index is explicitly deferred (7-day TTL bounds per-site volume to a manageable size)/preflight/beta/jobsis removed (replaced by new endpoints), not deprecated;/preflight/jobsis the only legacy endpoint continuing in parallelRelated
Generated with Claude Code