fix: announce step state in StepList's accessible name#9888
Merged
yihuiliao merged 2 commits intoadobe:mainfrom Apr 21, 2026
Merged
fix: announce step state in StepList's accessible name#9888yihuiliao merged 2 commits intoadobe:mainfrom
yihuiliao merged 2 commits intoadobe:mainfrom
Conversation
Add the VisuallyHidden stepStateText element to the aria-labelledby of each StepListItem link so screen readers announce the step state (Current/Completed/Not completed) as part of the accessible name. This ensures conformance with WCAG SC 2.5.3 Label in Name (Level A) by including the visually hidden but rendered step state text in the computed accessible name for each step. Closes adobe#9881
majornista
approved these changes
Apr 10, 2026
There was a problem hiding this comment.
Pull request overview
Updates StepListItem so the step state text (Current/Completed/Not completed), which is already rendered via VisuallyHidden, is now included in each step link’s accessible name to satisfy WCAG 2.5.3 “Label in Name”.
Changes:
- Add a dedicated
stateIdand include it in the link’saria-labelledbyalongside the marker and label IDs. - Assign the
stateIdto theVisuallyHiddenstep state element so it can be referenced byaria-labelledby. - Add a unit test verifying
aria-labelledbyreferences marker/state/label elements and that the referenced state element contains the expected state text.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/@adobe/react-spectrum/src/steplist/StepListItem.tsx | Includes step state text in the link’s accessible name by adding stateId to aria-labelledby and applying it to the visually hidden state element. |
| packages/@adobe/react-spectrum/test/steplist/StepList.test.tsx | Adds coverage to confirm the new aria-labelledby structure and that the state text element is present and populated. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
LFDanLu
approved these changes
Apr 15, 2026
yihuiliao
changed the title
yihuiliao
added
the
no testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9881
✅ Pull Request Checklist:
📝 Test Instructions:
StepListwith multiple items and various completion statesaria-labelledbyattribute — it should reference three IDs: the marker number, the step state text (Current/Completed/Not completed), and the labelyarn jest --no-watchman packages/@adobe/react-spectrum/test/steplist/StepList.test.tsx🧢 Your Project:
Open source accessibility contribution