fix(security): 2 improvements across 2 files#5031
Open
tomaioo wants to merge 2 commits into
Open
Conversation
- Security: Hardcoded Database Credentials in Scripts - Security: Hardcoded Database Credentials in Regen Script Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
- Security: Hardcoded Database Credentials in Scripts - Security: Hardcoded Database Credentials in Regen Script Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
IPR Policy Agreement Required@tomaioo — thanks for the contribution. Before this PR can be merged, the AgenticAdvertising.Org IPR Policy requires your agreement. To agree, post a new comment on this PR with the exact phrase: Your signature is recorded once and covers all contributions to AAO repositories. See |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(security): 2 improvements across 2 files
Problem
Severity:
Critical| File:scripts/gen-member-illustrations.ts:L6Multiple scripts contain hardcoded PostgreSQL connection strings with plaintext credentials (postgresql://adcp:localdev@localhost:62576/adcp_registry). These credentials are embedded directly in source code rather than being loaded from environment variables or a secrets manager, making them visible in version control and accessible to anyone with repository access.
Solution
Move all database credentials to environment variables (e.g., process.env.DATABASE_URL) and validate their presence at runtime. Use a shared configuration module that enforces secure credential loading.
Changes
scripts/gen-member-illustrations.ts(modified)scripts/regen-illustrations.ts(modified)