[codex] Add signal definition enrichment#5017
Draft
bokelley wants to merge 23 commits into
Draft
Conversation
67f6962 to
5035ba7
Compare
bc5221c to
03db9db
Compare
03db9db to
fd41e83
Compare
54c07c4 to
e61c5b2
Compare
e61c5b2 to
1c9aa17
Compare
…ys' into bokelley/review-signal-schema-followup # Conflicts: # .changeset/signal-targeting-overlay.md # docs/media-buy/advanced-topics/targeting.mdx # docs/media-buy/product-discovery/media-products.mdx # docs/media-buy/task-reference/create_media_buy.mdx # docs/media-buy/task-reference/get_products.mdx # docs/media-buy/task-reference/sync_audiences.mdx # docs/protocol/capabilities-explorer.mdx # docs/protocol/get_adcp_capabilities.mdx # docs/reference/glossary.mdx # docs/signals/data-providers.mdx # docs/signals/key-concepts.mdx # docs/signals/tasks/get_signals.mdx # static/schemas/source/adagents.json # static/schemas/source/core/package-signal-targeting.json # static/schemas/source/core/product-signal-targeting-option.json # static/schemas/source/core/product.json # static/schemas/source/core/signal-definition.json # static/schemas/source/core/signal-id.json # static/schemas/source/core/signal-ref.json # static/schemas/source/core/signal-targeting-rules.json # static/schemas/source/core/targeting.json # static/schemas/source/core/x-entity-types.json # static/schemas/source/index.json # static/schemas/source/protocol/get-adcp-capabilities-response.json # static/schemas/source/signals/get-signals-response.json # tests/composed-schema-validation.test.cjs
…ys' into bokelley/review-signal-schema-followup
1c9aa17 to
d0afd3f
Compare
…ys' into bokelley/review-signal-schema-followup
d0afd3f to
bd541f8
Compare
…ys' into bokelley/review-signal-schema-followup
bd541f8 to
9dbc80e
Compare
…ys' into bokelley/review-signal-schema-followup
9dbc80e to
92e49f4
Compare
Adds one sentence clarifying that the seller_planned model applies to any time-bound supply scheduled in advance, not only linear broadcast audio — live sports, political programming, and tentpole broadcasts follow the same primitive. Prompted by iHeartMedia AudioGraph comment on PR thread. https://claude.ai/code/session_019VvFeX77WCZen9dZCmkgsq
…ys' into bokelley/review-signal-schema-followup
…ys' into bokelley/review-signal-schema-followup # Conflicts: # docs/media-buy/product-discovery/media-products.mdx # docs/media-buy/task-reference/create_media_buy.mdx # docs/media-buy/task-reference/get_products.mdx # static/schemas/source/core/product-filters.json
…l-schema-followup # Conflicts: # .changeset/signal-targeting-overlay.md # docs/media-buy/advanced-topics/targeting.mdx # docs/media-buy/product-discovery/media-products.mdx # docs/media-buy/task-reference/create_media_buy.mdx # docs/media-buy/task-reference/get_products.mdx # docs/media-buy/task-reference/sync_audiences.mdx # docs/protocol/capabilities-explorer.mdx # docs/protocol/get_adcp_capabilities.mdx # docs/reference/glossary.mdx # docs/reference/whats-new-in-3-1.mdx # docs/signals/data-providers.mdx # docs/signals/key-concepts.mdx # docs/signals/specification.mdx # docs/signals/tasks/activate_signal.mdx # docs/signals/tasks/get_signals.mdx # static/compliance/source/protocols/media-buy/index.yaml # static/schemas/source/adagents.json # static/schemas/source/core/package-signal-targeting.json # static/schemas/source/core/product-filters.json # static/schemas/source/core/product-signal-targeting-option.json # static/schemas/source/core/product.json # static/schemas/source/core/signal-definition.json # static/schemas/source/core/signal-id.json # static/schemas/source/core/signal-listing.json # static/schemas/source/core/signal-ref.json # static/schemas/source/core/targeting.json # static/schemas/source/core/x-entity-types.json # static/schemas/source/index.json # static/schemas/source/protocol/get-adcp-capabilities-response.json # static/schemas/source/signals/get-signals-response.json # tests/composed-schema-validation.test.cjs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends
core/signal-definition.jsonwith definition-side enrichment for signal meaning, methodology, modeling, jurisdiction applicability, consent basis, and per-signal data-subject-rights routing.This keeps #5009's separation intact: product/buy-time composition stays on product signal targeting options, while stable signal semantics live on the published signal definition.
Key decisions
signal-value-type.taxonomy.value_mappingsso categoricalallowed_values[]can map to stable taxonomy nodes without changing the wire value grammar.taxonomy.parent_match_behaviorso descendant expansion is explicit seller behavior, not an implicit schema rule.data_subject_rightsrouting to avoid duplicating{url,email}blocks per right.core/signal-modeling-disclosure.jsoninstead of reusing creativeprovenance.disclosure, because modeled data-signal disclosure is not content provenance/render guidance.panelas a signaldata_sourcesvalue for JIC/panel-derived audiences, while keeping co-viewing uplift and seller/JIC reconciliation on measurement/vendor-metric surfaces.get_signalsfor candidate discovery, then confirm product eligibility/composability throughget_products.filters.signal_targetingor the product response beforecreate_media_buy.selection_groupand targeting-mode composition concerns out ofsignal-definition; those remain product/buy-time concerns.adagents.jsonsignals[], avoiding confusion withsync_catalogs.get_signals/product workflow guidance, and JIC/panel measurement placement.Validation
npm run test:schemasnpm run test:composednpm run test:schema-utf8npm run test:json-schemanpm run test:storyboard-context-entitynpm run check:x-entity-gaps(informational existing-gap report only)git diff --checktest:unit,test:test-dynamic-imports,test:callapi-state-change,typecheck