Upgrade e2e TypeScript to 7.x#23
Merged
Merged
Conversation
TypeScript 7 is the native (Go-based) compiler rewrite. It no longer auto-includes @types packages under this config, so node types are now listed explicitly, and the target is raised to ES2022 so lib typings cover Promise.any used in the tests. Playwright transpiles test files itself at runtime; typescript here is for type-checking and editor support. `tsc -p . --noEmit` passes cleanly with 7.0.2. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Keeps TypeScript 7.0.2 from this branch while taking main's newer @playwright/test 1.61.1 and @types/node 26.1.1. Lockfile regenerated from main's version via npm install. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps
typescriptine2e/from^5.6.0to^7.0.2(lockfile resolves to 7.0.2, the latest stable). This is the focused TypeScript 5.x → 7.x upgrade that was deliberately left out of the recent general dependency bump: TS 7 is the new native compiler (the Go-based rewrite), so it warranted its own PR.The
frontend/directory is Elm and is untouched.tsconfig adjustments
Two minimal changes to
e2e/tsconfig.jsonwere needed for the new compiler:"types": ["node"]— TS 7 no longer picked up the installed@types/nodeautomatically under this config, producingTS2591: Cannot find name 'Buffer'/'process'/...throughout the Playwright type definitions andplaywright.config.ts. Listing node types explicitly resolves it."target": "ES2020"→"ES2022"— the test sources usePromise.any, which needs ES2021+ lib typings (TS2550). ES2022 matches the Node versions we run on. (Playwright transpiles test files itself at runtime, sotargethere only affects type-checking.)No test-source changes were needed.
Verified locally
npx tsc --version→Version 7.0.2npx tsc -p . --noEmitine2e/→ exits 0, no errors over the test sources andplaywright.config.tsnpm installrefreshede2e/package-lock.json(TS 7 ships per-platform native binaries as@typescript/typescript-*optional deps, hence the larger lockfile diff)CI
The E2E Tests (local) check on this PR runs the actual Playwright suite against a locally-built stack, which exercises the upgraded toolchain end to end.
🤖 Generated with Claude Code