AK-508: add .gitignore for agent review-findings dirs - #4
Draft
benw5483 wants to merge 1 commit into
Draft
Conversation
Automated review tooling writes `.architect/` and `.reviewer/` at the repo root of a working tree. Those directories hold internal run identifiers and raw review commentary, so a broad `git add -A` could sweep them into a PR. This repo had no `.gitignore` at all, so this adds one covering both patterns plus a `.DS_Store` baseline. Verified before committing: no tracked file matched either pattern, so the rule is purely preventive and untracks nothing. Generated by the operator's software factory. City: factory-main · Agent: local-core__builder-fm-session-c20ba9dca735092c301bd842f4e87b44 On behalf of: @benw5483 Co-Authored-By: operator-factory-bot <factory-bot@actual.ai.invalid>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.gitignoreto this repo, which had none, so automated review tooling's findings directories can never be committed here..architect/and.reviewer/, the gate-findings directories agent tooling writes at the repo root. They carry internal run identifiers and raw review commentary, so a broadgit add -Amust not sweep them into a PR..DS_Storeas the ordinary baseline. Nonode_modules/or Python entries, because this repo tracks only Markdown, JSON, YAML, one shell script, and one image. Neither language is present.Verified before committing
git ls-files | grep -E '^\.(architect|reviewer)/'returns nothing onmain, so no findings file was ever committed to this repo. The new rule is purely preventive and untracks nothing.The diff is one new file and eight added lines. Nothing is removed, reordered, or otherwise touched.
Test plan
git check-ignore -v .architect/round-1.findings.json .reviewer/round-1.findings.jsonnames.gitignoreas the matching source for both paths.git ls-files | grep -E '^\.(architect|reviewer)/'is empty, confirming nothing matching was already tracked..architect/directory in a clone, then confirmgit status --porcelainstays clean.