fix(advisor): honor configured API URL - #814
Draft
wattswolf wants to merge 1 commit into
Draft
Conversation
wattswolf
marked this pull request as draft
July 31, 2026 03:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actual advisorresolve its API base URL in this order:--api-url, non-emptyACTUAL_API_URL, configuredapi_url, production default.Fixes AK-415.
Proof
main(production URL returned), then passed at4b6a8596DEFAULT_API_URLValidation:
cargo test --workspace --features integration(3,532 passed, 0 failed),cargo fmt --check,cargo clippy -- -D warnings, andcargo build --release.Risk is limited to Advisor URL selection when no explicit override is supplied. Rollback is the single commit.