Skip to content

Replace sha1 dependency with sha-1 - #1258

Merged
JohnTitor merged 3 commits into
actix:masterfrom
linkmauve:sha-1
Jan 10, 2020
Merged

Replace sha1 dependency with sha-1#1258
JohnTitor merged 3 commits into
actix:masterfrom
linkmauve:sha-1

Conversation

@linkmauve

Copy link
Copy Markdown
Contributor

This other crate is being maintained, and it offers better performances when using the asm feature (especially on AArch64).

JohnTitor
JohnTitor previously approved these changes Jan 6, 2020

@JohnTitor JohnTitor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update CHANGES.md?

@linkmauve

Copy link
Copy Markdown
Contributor Author

Done.

@codecov

codecov Bot commented Jan 6, 2020

Copy link
Copy Markdown

Codecov Report

Merging #1258 into master will increase coverage by 2.49%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1258      +/-   ##
==========================================
+ Coverage   77.98%   80.47%   +2.49%     
==========================================
  Files         159      159              
  Lines       18538    18541       +3     
==========================================
+ Hits        14456    14921     +465     
+ Misses       4082     3620     -462
Impacted Files Coverage Δ
actix-http/src/ws/proto.rs 96.87% <100%> (+0.07%) ⬆️
actix-http/src/h1/dispatcher.rs 73.73% <0%> (+0.48%) ⬆️
actix-http/src/message.rs 83.42% <0%> (+0.55%) ⬆️
actix-http/src/h1/encoder.rs 84.17% <0%> (+0.59%) ⬆️
actix-http/src/response.rs 84.58% <0%> (+0.88%) ⬆️
src/middleware/compress.rs 68.18% <0%> (+1.51%) ⬆️
actix-http/src/client/h2proto.rs 74.69% <0%> (+2.4%) ⬆️
actix-http/src/encoding/encoder.rs 72.18% <0%> (+3%) ⬆️
awc/src/builder.rs 67.3% <0%> (+5.76%) ⬆️
actix-http/src/client/connector.rs 44.21% <0%> (+6.8%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e66312b...84be66a. Read the comment docs.

@JohnTitor

Copy link
Copy Markdown
Member

Sorry again, could you rebase to make CI green?

@JohnTitor

Copy link
Copy Markdown
Member

Ah, could you add a unit test to confirm that the output isn't changed?

like:

#[test]
fn test_hash_key() {
    let foo = hash_key("hello actix-web".as_bytes());
    assert_eq!(&foo, "cR1dlyUUJKp0s/Bel25u5TgvC3E=");
}

@JohnTitor
JohnTitor dismissed their stale review January 9, 2020 22:48

needs a test

This other crate is being maintained, and it offers better performances
when using the `asm` feature (especially [on
AArch64](RustCrypto/hashes#97)).
@linkmauve

Copy link
Copy Markdown
Contributor Author

Done.

@JohnTitor
JohnTitor merged commit abb462e into actix:master Jan 10, 2020
@JohnTitor

Copy link
Copy Markdown
Member

Thanks!

@linkmauve
linkmauve deleted the sha-1 branch January 10, 2020 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants