Skip to content

Adds info for symbolic calc lesson to symmath module - #50

Merged
jchen0506 merged 1 commit into
act-cms:mainfrom
dsirianni:symalg
Jul 31, 2026
Merged

Adds info for symbolic calc lesson to symmath module#50
jchen0506 merged 1 commit into
act-cms:mainfrom
dsirianni:symalg

Conversation

@dsirianni

Copy link
Copy Markdown
Contributor

No description provided.

@dsirianni

Copy link
Copy Markdown
Contributor Author

@jchen0506 This is ready to go, apologies for the failing check due to the same error as my last PR.

@jchen0506 jchen0506 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jchen0506
jchen0506 merged commit b197fc5 into act-cms:main Jul 31, 2026
1 check failed
Copilot AI added a commit that referenced this pull request Jul 31, 2026
…cess

The job was failing with HTTP 403 when trying to post a PR comment
because PR #50 was a fork PR (dsirianni/portal → act-cms/portal).
With the `pull_request` trigger, GitHub's GITHUB_TOKEN is read-only
for fork PRs regardless of the declared `issues: write` permission.

Fix: switch to `pull_request_target`, which runs in the base-repo
context and always honours the declared permissions.

Security: after checking out the PR head content, all executable files
(scripts/, templates/, template.yaml, paths.yml, index.html, theme.css)
are restored from the trusted base branch SHA. Only the lesson YAML
data files from the fork are used, and those are only parsed, not
executed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants