Skip to content

Add cylindrical geometry#41

Merged
acreyes merged 55 commits into
mainfrom
acreyes/geometry
Apr 23, 2026
Merged

Add cylindrical geometry#41
acreyes merged 55 commits into
mainfrom
acreyes/geometry

Conversation

@acreyes

@acreyes acreyes commented Mar 23, 2026

Copy link
Copy Markdown
Owner

Introduces a wrapper around parthenon uniform coordinates to enable runtime curvilinear coordinates. Starting with 2d axisymmetric.

TODO:

  • mhd
  • prolongation for face fields
  • baselines

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b34c00d186

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/grid/geometry.hpp Outdated
@github-actions

Copy link
Copy Markdown
Contributor

Documentation available at: https://acreyes.github.io/kamayan/acreyes-geometry

@acreyes acreyes force-pushed the acreyes/geometry branch from b34c00d to 04eef66 Compare April 6, 2026 04:54
@acreyes

acreyes commented Apr 22, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d93781a3a2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/grid/coordinates.hpp Outdated
Comment thread tests/test_suites/mhd_blast/mhd_blast.py Outdated
Comment thread tests/test_suites/mhd_blast/mhd_blast.py Outdated
acreyes added 2 commits April 22, 2026 13:04
Signed-off-by: Adam C Reyes <adam.c.reyes@gmail.com>
@acreyes acreyes merged commit 202ba24 into main Apr 23, 2026
15 checks passed
@acreyes acreyes deleted the acreyes/geometry branch April 23, 2026 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant