gpu: snapshot per-batch LOD timing across batch boundary#160
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #154.
The per-level (LOD) timing in the metrics could read slightly wrong values. A batch's timing was read after it finished, but by then the next batch could have reused and overwritten those timers. These numbers are only for reporting, so written data was never affected — only the timing readout could be off.
Fix: give each in-flight batch its own set of timers (enough for the most that can be active at once), so a batch's timing is read from its own set rather than a later batch's. The ordering signal that had been sharing one of those timers is split out, leaving the timers purely for measurement. Batches that do no per-level work (a trailing partial write) are marked so the reader skips their timers instead of reading stale ones.
Reporting only; no change to written data.