Khang/timeline component - #30
Closed
khanggn wants to merge 3 commits into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This looks really good! One note is that I think the timeline should automatically start at the earliest possible date which has not yet passed; do you think we can add this? For example, if the deadline for Application Opens has already passed, when users navigate to the page it should automatically start on the Application Deadline in the timeline. |
NathanRLiu
previously approved these changes
Jul 13, 2026
NathanRLiu
marked this pull request as draft
July 13, 2026 02:22
NathanRLiu
marked this pull request as ready for review
July 13, 2026 02:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
note: im not sure if the design team discussed about this during their meeting but i think it would be important talking about the font size, spacing, alignment, etc... so that the website will look more consistent.