os/bluestore: improve stray spanning blobs fix#3
Open
ifed01 wants to merge 4 commits into
Open
Conversation
ifed01
force-pushed
the
wip-ifed-improve-stray-spanning-blobs-fix
branch
from
a98d964 to
1619980
Compare
aclamk
force-pushed
the
aclamk-bs-fix-stray-spanning-blobs
branch
from
e97b6f3 to
e4804d2
Compare
ifed01
force-pushed
the
wip-ifed-improve-stray-spanning-blobs-fix
branch
from
1619980 to
cf1b1ce
Compare
Signed-off-by: Igor Fedotov <igor.fedotov@croit.io> (cherry picked from commit 9c61bb87ebaa183ffe20e66eba4c73fbe28d39a8)
Signed-off-by: Igor Fedotov <igor.fedotov@croit.io> (cherry picked from commit 5ff275a4bf678ece9836c343ca3d428c0ab70134)
Failing to do that could cause "left" blob to keep having invalid pextents at the end. Which we prefer to avoid. Signed-off-by: Igor Fedotov <igor.fedotov@croit.io> (cherry picked from commit b9b25eacceac3463266d1339656b1ef1f156d858)
inappropriate. Signed-off-by: Igor Fedotov <igor.fedotov@croit.io> (cherry picked from commit 3f808ed9515bf65f86dbf1756d0fe7b2dd19ed93)
ifed01
force-pushed
the
wip-ifed-improve-stray-spanning-blobs-fix
branch
from
cf1b1ce to
52be63c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@aclamk - mind to take this patch into your stray spanning blobs fix?
This includes more tests (primarily) and performs additional blob's tail prunning when splitting.