Add option to exclude private PSL names and associated test#20
Open
kitterma wants to merge 1 commit into
Open
Conversation
Signed-off-by: Scott Kitterman <scott@kitterman.com>
KnitCode
approved these changes
Dec 3, 2021
KnitCode
left a comment
KnitCode
left a comment
Contributor
There was a problem hiding this comment.
seems reasonable to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently on the IETF DMARC Working Group mailing list there is discussion about how for DMARC's use of the PSL it might be better to exclude the private names portion of the PSL from consideration. It would be nice to be able to support analysis on this point in Python, so I implemented an option to exclude the private names.
It seems like this might be more generally useful, so here you go. Ideally it'd be nice to see a release with this. There shouldn't be any backward compatibility issues and an appropriate test is included. All existing tests pass.