[codex] Pluggable Tool Registry#2
Draft
aboimpinto wants to merge 15 commits into
Draft
Conversation
aboimpinto
force-pushed
the
feat/external-tool-pr2-stacked-clean
branch
5 times, most recently
from
f7660df to
ce84cf0
Compare
Harvested with thanks to @aboimpinto. Includes the ExternalTool abstraction layer plus follow-up fixes for lossy REPL stdout handling and unquoted unicode git diff paths. Validation included full CI and focused local checks for non-UTF8 REPL stdout, git_diff, and external_tool behavior.
Harvested from Hmbown#2407 with thanks to @axobase001. Adds a first-time macOS Python FAQ and completes the virtualenv flow with the final run command. Fixes Hmbown#2351.
Harvested from Hmbown#2406 with thanks to @axobase001. Adds auto-selected model and reasoning effort to turn metadata while keeping user text isolated in its own content block. Includes the comment cleanup requested in review. Partially addresses Hmbown#2380.
Harvested from Hmbown#2400 with thanks to @axobase001.\n\nAligns the configuration docs around CODEWHALE_HOME while preserving the DEEPSEEK_HOME legacy alias and spelling out how legacy checkpoints can still be scanned during cleanup.\n\nCloses Hmbown#2322.
Harvested from Hmbown#2405 with thanks to @axobase001.\n\nCompacts the statusline token chip to use the short label while preserving the existing token detail and adding focused coverage for the rendered label.\n\nPartially addresses Hmbown#2309.
Harvested from Hmbown#2408 with thanks to @axobase001. Adds regression coverage proving tty:true shell commands receive a controlling terminal, with a longer wait margin so the test is stable on slower CI hosts. Partially addresses Hmbown#2372.
Harvested from Hmbown#2415 with thanks to @axobase001. Keeps the denser mobile QR renderer and replaces the fixed binding-warning sleep with health polling plus an explicit timeout failure path, so slow starts fail with the useful cause instead of drifting into misleading assertions. Follow-up to Hmbown#2403.
aboimpinto
force-pushed
the
feat/pluggable-tool-registry-pr3-stacked
branch
from
f18db1c to
60cf7a3
Compare
Harvested from Hmbown#2402 with thanks to @axobase001. Keeps `allow_shell` guidance visible for gated shell tools even when missing-tool suggestions exist, removes the nonexistent task_shell_cancel matcher, and broadens regression coverage. Partially addresses Hmbown#2328.
Harvested from Hmbown#2392 with thanks to @wplll. Makes project context pack path ordering deterministic across Unix and Windows-style separators while keeping README/config/source entries prioritized before general directory noise.
Harvested from Hmbown#2393 with thanks to @wplll. Strengthens the tool-result dedup regression coverage by exercising repeated medium-sized outputs that are above the dedup threshold but below the truncation budget.
Harvested from Hmbown#2343 with thanks to @lucaszhu-hue. Registers AtlasCloud static model rows for Pro and Flash resolution, adds provider-hinted alias coverage, and updates neutral provider docs and env examples while leaving promotional assets/copy out.
aboimpinto
force-pushed
the
feat/pluggable-tool-registry-pr3-stacked
branch
from
60cf7a3 to
e3a2681
Compare
Harvested from Hmbown#2377 with thanks to @buko. Threads the parent MCP tool pool into child SubAgentRuntime construction and registers MCP-backed tools for child agents when MCP is enabled, while leaving the broader mention-browser/provider/config work for focused follow-ups. Validation: - cargo fmt --all -- --check - CARGO_TARGET_DIR=/Volumes/VIXinSSD/codewhale-pr2377-target cargo test -p codewhale-tui tools::subagent - CARGO_TARGET_DIR=/Volumes/VIXinSSD/codewhale-target/harvest-2377-recheck cargo test -p codewhale-tui tools::subagent --all-features
Follow-up on Hmbown#2420 after the contributor branch update. Keeps explicit overrides above auto-discovered tools, makes directory scan ordering deterministic, and fixes the audit wrapper example.
Hmbown
force-pushed
the
feat/pluggable-tool-registry-pr3-stacked
branch
from
6f8374a to
a637159
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the third stacked layer on top of Hmbown#2294: pluggable tool registry support for runtime registration, config.toml overrides, and plugin discovery.
What changed:
tools_always_loadbehavior from the stacked shell branch[tools]support forplugin_dirand per-tooloverridesWhy:
Validation:
cargo fmt --allcargo check -p codewhale-tui --all-features --lockedcargo test -p codewhale-tui test_parse_frontmatter_full -- --nocapturecargo test -p codewhale-tui test_load_plugin_tools_creates_tools -- --nocapturecargo test -p codewhale-tui test_tool_from_override_script -- --nocapturePaulo Aboim Pinto