Alternative polyA/TSS terminal-end transcript discovery + reference-consistent model assignment#398
Merged
Merged
Conversation
…transcript_ends flag
…; keep genedb behavior unchanged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This branch adds alternative-terminal (polyA/TSS) transcript-model discovery and makes the model-side read assignment and quantification consistent with the reference-based path, building on the existing graph-based model construction.
What's new
1. PolyA / TSS terminal-site prediction
SAMPLE.polyA_prediction.tsv/SAMPLE.TSS_prediction.tsv(gated by--genedb; TSS additionally by--fl_data).2. Alternative-end (polyA/TSS) NIC discovery
--genedb(the interim--refine_transcript_endsflag was dropped). Two mechanisms: a graph-level reclassification when a refined FL-path terminal vertex disagrees with the matched reference end, and a post-construction per-transcript pass that peak-calls a known model's own reads for confident alternative ends (relative-support gated, intron-chain/ends deduped).--novel_apa(hidden, opt-in) extends alt-end creation to novel chains.--genedb): only end polishing runs — transcript models are unchanged from base behavior.--terminal-deltagffcompare fork at three terminal tolerances (default/50/10), since the default gffcompare metric is end-agnostic for multi-exon transcripts. New alt-end-discovery CI configs + workflows and a simulation reduced-db prep script are included.3. Read-assignment gate + model-counting refactor
--genedb.add_read_info(ReadAssignment)path as the reference counters; the redundantadd_read_info_rawAPI is deleted throughout (including no-op stubs on the exon counters).Validation
transcript_countsand discovered-modeltranscript_countson ONT (R10corr_overlap0.94 → 0.99, R9 0.991 → 0.996); PacBio was already near-perfect — the same known isoform is now quantified consistently by both paths.🤖 Generated with Claude Code