fix #8: poller delta-merge for persisted target temps#27
Merged
Conversation
The Bambu printer only re-publishes fields that *changed* in subsequent MQTT report messages. nozzle_target_temper arrives in the initial pushall and then never again until the user changes the target. The poller's formatter was reading directly from each incoming payload, so subsequent updates without the target field rendered 'nozzle 220/0'. Fix: introduce merge_delta() that updates a long-lived snapshot dict, skipping None and empty values so transiently missing fields don't blow away known values. on_message merges into the snapshot and formats from it. Closes #8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8. 10 new tests in tests/test_poller.py covering merge precedence, target persistence across delta updates, edge cases. 61 total passing.