fix: respect Blacklist/Whitelist options for single-language scripts#30
Open
Yanhu007 wants to merge 1 commit into
Open
fix: respect Blacklist/Whitelist options for single-language scripts#30Yanhu007 wants to merge 1 commit into
Yanhu007 wants to merge 1 commit into
Conversation
Languages detected by script alone (Han, Bengali, Hangul, etc.) bypassed the Options check entirely, ignoring both Blacklist and Whitelist. Only multi-language scripts (Latin, Cyrillic, etc.) went through detectLangInProfiles which checks options. Add filterLangByOptions helper that validates single-language script detections against Blacklist/Whitelist before returning. Fixes abadojack#28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #28
Problem
Languages detected by unique script (Han→Mandarin, Bengali→Bengali, Hangul→Korean, etc.) bypassed
Optionsentirely. Blacklist and Whitelist were only checked for multi-language scripts (Latin, Cyrillic, etc.) that go throughdetectLangInProfiles.Fix
Add
filterLangByOptionshelper that checks Blacklist/Whitelist before returning single-language script detections. If the language is filtered out, returns(-1, 0)(unknown).Testing
All existing tests pass. Manually verified: