Skip to content

changes caused by org-format-latex#2

Open
EvgeniiFrolov wants to merge 1 commit into
aaptel:masterfrom
EvgeniiFrolov:master
Open

changes caused by org-format-latex#2
EvgeniiFrolov wants to merge 1 commit into
aaptel:masterfrom
EvgeniiFrolov:master

Conversation

@EvgeniiFrolov

Copy link
Copy Markdown

As I've already said, compiling file ~/.emacs.d/elpa/px-20141006.548/px.el from elpa with emacs pachage manager finished with the following warning:

In px--create-preview:
px.el:65:4:Warning: org-format-latex called with 7 arguments, but accepts only
1-6

And px-preview stopped working.

I've tried downloading the package and adjusting the number of arguments.
As know almost nothing about lisp, I thought that "at" is odd and tried deleting it and recompiling on my own. That worked. The function px-toggle works for me again.
Now want to create my first pull request) Don't judge to severe)
What would you say?
What steps are needed for changes to reach the elpa repo?

@EvgeniiFrolov

Copy link
Copy Markdown
Author

And did px-preview-region stopped working because of my changes?
I ask this as I've never used it before, tried now (with both new and old versions of px.elc) and it did not work out!

@EvgeniiFrolov

Copy link
Copy Markdown
Author

Any thoughts on the issue?

@aaptel

aaptel commented Sep 24, 2015

Copy link
Copy Markdown
Owner

Sorry I'm really busy... I'll have a look at this next week!

@EvgeniiFrolov

Copy link
Copy Markdown
Author

That is totally ok, busy too this time!
Wait for your response, however)
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants