Skip early PotionBrewing.bootstrap() to fix crash with Alex's Mobs Continued - #349
Open
altspaced wants to merge 1 commit into
Open
Skip early PotionBrewing.bootstrap() to fix crash with Alex's Mobs Continued#349altspaced wants to merge 1 commit into
altspaced wants to merge 1 commit into
Conversation
Skip early PotionBrewing.bootstrap() to fix Alex's Mobs crash Calling PotionBrewing.bootstrap() during early recipe registration causes a "Components not bound yet" crash when Alex's Mobs is present. Temporarily skip the early registration as a compatibility fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Calling
PotionBrewing.bootstrap()during early recipe registration causes aNullPointerException: Components not bound yetwhen Alex's Mobs Continued is installed.Solution
Temporarily skip the early registration of potion mixing recipes.
This prevents the crash while keeping all other Create features working.
Testing