introduced config-option JobsTop.IncludeArchivedStats#1958
Open
BlvckBytes wants to merge 1 commit intoZrips:masterfrom
Open
introduced config-option JobsTop.IncludeArchivedStats#1958BlvckBytes wants to merge 1 commit intoZrips:masterfrom
BlvckBytes wants to merge 1 commit intoZrips:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greetings!
This rather concise patch gives users the option to select whether or not to include the statistics (level, experience) of archived jobs in
/jobs topand/jobs gtop, seeing how multiple users desired this feature.Also, I've added two more calls to update global top, seeing how we've noticed that in some cases, one had to join/leave jobs as for it to get updated; now, it simply pushes an update after loading the user from persistence.
I'd be super thankful if we could get this merged and thereby make it become available for the whole community.
Please let me know if you'd like me to make any further adjustments to my changes - I'm happy to do so.