Re-run Command After Interaction#69
Open
phulstaert wants to merge 1 commit into
Open
Conversation
+ bugfixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New feature
I added functionality to automatically re-run the main command after the user performs an action (clicking the widget or scrolling). This allows a longer command interval, while keeping the responsiveness high after an action.
(ex: click to toggle a light and rerun the command that polls the state of the ligt)
bugfixes and 'beautification'
ANSI RGB & 256-Color Parsing
Fixed a logic error in parseAnsiEscape where multi-token ANSI codes (like \033[38;2;R;G;Bm for RGB colors) were not consuming the correct number of arguments.
The parser now correctly advances the token index by consuming the appropriate number of values for RGB (4 tokens) and 256-color (2 tokens) modes, preventing subsequent numbers from being misinterpreted as new formatting codes.
HTML Tag Nesting
Fixed resetState to close HTML tags in the reverse order they were opened (e.g.,
<b><font>becomes</font></b>), ensuring valid HTML syntax which prevents potential rendering artifacts.Configuration Refactoring
Updated the file to use the standardized configKey property approach instead of manual property alias cfg_... bindings. This aligns the coding style with ConfigActions.qml and ConfigAppearance.qml.
Warning Suppression
Added dummy properties (e.g., property var cfg_interval, cfg_intervalDefault) to the base configuration component. This intercepts the properties automatically injected by the Plasma configuration loader, suppressing the verbose "Setting initial properties failed" warnings in the system logs.