Harden cache clear request sanitization#98
Closed
Zodiac1978 wants to merge 7 commits into
Closed
Conversation
plugins_api() can return a valid object (not WP_Error) that lacks expected properties like `version`. This happens with plugins like Search & Filter Pro whose slug collides with a wp.org entry returning invalid data. Guard against this in two places: - assemble_plugin_report(): reject API responses missing `version` before caching as repo_info - render_table_row(): add isset() check on version, consistent with tested/rating/last_updated guards Fixes #56
Move the isset(version) check inside the non-error branch so the else is only reached for WP_Error, letting PHPStan narrow the type correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Harden cache clear request sanitization