security: bump ws and concurrently to fix high/critical CVEs#54
Open
Vishnu-tppr wants to merge 1 commit into
Open
security: bump ws and concurrently to fix high/critical CVEs#54Vishnu-tppr wants to merge 1 commit into
Vishnu-tppr wants to merge 1 commit into
Conversation
Code Review by Qodo
1. Node engine mismatch
|
PR Summary by QodoSecurity: bump ws and concurrently to address high/critical CVEs WalkthroughsDescription• Bump ws to ^8.21.0 to remediate WebSocket parser DoS/memory issues. • Bump concurrently to ^10.0.3 to remediate prototype-pollution issues in sub-deps. Diagramgraph TD
A["package.json"] --> B["ws"]
A["package.json"] --> C["concurrently"]
B --> D["Runtime networking"]
C --> E["Dev scripts"]
High-Level AssessmentThe following are alternative approaches to this PR: 1. Use npm overrides/resolutions (temporary mitigation)
2. Enable automated dependency PRs (Renovate/Dependabot)
Recommendation: The PR’s approach (bumping the direct dependencies) is the preferred long-term fix versus relying on overrides. Ensure the corresponding lockfile is updated in the PR (if applicable) and verify CI/test runs plus an npm audit (or your security scanner) reflect the reduced/cleared critical/high findings. File ChangesOther (1)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're bumping the versions of ws and concurrently to fix multiple CVEs in sub-dependencies. This drops our active vulnerabilities from 26 down to 11, and completely eliminates critical alerts.
Bumps: