Skip to content

[codex] Simplify Quartus CI build#1

Merged
asturur merged 1 commit into
masterfrom
codex/simple-quartus-action
May 6, 2026
Merged

[codex] Simplify Quartus CI build#1
asturur merged 1 commit into
masterfrom
codex/simple-quartus-action

Conversation

@asturur
Copy link
Copy Markdown
Member

@asturur asturur commented May 6, 2026

Summary

  • Replace the remote MiSTer build automation handoff with a direct GitHub Actions Quartus build.
  • Build menu using the Quartus Lite Cyclone V Docker image.
  • Verify output_files/menu.rbf is produced and upload it as a workflow artifact.

Validation

  • Parsed .github/workflows/ci_build.yml locally with Ruby YAML.
  • Did not run a full Quartus compile locally.

Summary by CodeRabbit

  • Chores
    • Updated build automation workflow to use containerized build system with improved permission restrictions and artifact handling.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 6, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5252ff82-2697-4e55-8395-e15991e11a5b

📥 Commits

Reviewing files that changed from the base of the PR and between 0d54d02 and 5c09db7.

📒 Files selected for processing (1)
  • .github/workflows/ci_build.yml

📝 Walkthrough

Walkthrough

The CI workflow is refactored from executing a remote build script to using a containerized Quartus Lite build. It adds explicit triggers, restricted permissions, output verification, and artifact uploads.

Changes

CI Workflow Containerization

Layer / File(s) Summary
Trigger Configuration
.github/workflows/ci_build.yml
Workflow triggers updated to pull_request, push, and workflow_dispatch.
Permissions & Container Setup
.github/workflows/ci_build.yml
Explicit permissions: contents: read added; job configured with theypsilon/quartus-lite-c5:17.0.2.docker0 container image.
Build Execution
.github/workflows/ci_build.yml
Script-based approach (curl-piped remote build.sh) replaced with docker run executing Quartus compile command for menu.
Output Verification & Artifact Upload
.github/workflows/ci_build.yml
Steps added to verify output_files/menu.rbf exists and upload it as artifact using actions/upload-artifact@v4.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes


🐰 From scripts to containers, a hop most grand,
Quartus builds now stand in Docker's land,
Permissions locked tight, artifacts take flight,
Our CI pipeline shines, clean and bright! 🚀

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/simple-quartus-action

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@asturur asturur marked this pull request as ready for review May 6, 2026 23:08
@asturur asturur merged commit cc7e30b into master May 6, 2026
3 of 4 checks passed
@asturur asturur deleted the codex/simple-quartus-action branch May 6, 2026 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant