Skip to content

docs(zaparoo): update fork map for two-page Launcher/Video split#3

Merged
asturur merged 1 commit into
masterfrom
feat/zaparoo-fb-toggle
May 10, 2026
Merged

docs(zaparoo): update fork map for two-page Launcher/Video split#3
asturur merged 1 commit into
masterfrom
feat/zaparoo-fb-toggle

Conversation

@asturur
Copy link
Copy Markdown
Member

@asturur asturur commented May 10, 2026

Reflects 7d6b40a:

  • right-side surface is now two pages (Launcher top + Video sub-page), files renamed to launcher_pages.{cpp,h}, symbols split into launcher_page_* / video_page_*
  • Scripts row back in trimmed System Settings
  • OSD auto-dismiss on launcher spawn (MenuHide in spawn())
  • CRT-mode-on-exit drops to HDMI for the rest of the session

Cleanup backlog: closes #2.10 (naming drift resolved), adds #2.11 (two OSD-dismiss paths) and #2.12 (CRT-on-exit policy).

Summary by CodeRabbit

  • Documentation
    • Updated internal developer documentation with reorganized system settings reference materials and clarified display mode behavior notes for improved maintainability.

Review Change Stack

Reflects 7d6b40a:
- right-side surface is now two pages (Launcher top + Video sub-page),
  files renamed to launcher_pages.{cpp,h}, symbols split into
  launcher_page_* / video_page_*
- Scripts row back in trimmed System Settings
- OSD auto-dismiss on launcher spawn (MenuHide in spawn())
- CRT-mode-on-exit drops to HDMI for the rest of the session

Cleanup backlog: closes #2.10 (naming drift resolved), adds #2.11 (two
OSD-dismiss paths) and #2.12 (CRT-on-exit policy).
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 10, 2026

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 85e36ba9-fb09-4f0c-8828-d8d3af0e577f

📥 Commits

Reviewing files that changed from the base of the PR and between 5bc1704 and 47b0b5c.

📒 Files selected for processing (1)
  • ZAPAROO_FORK.md

📝 Walkthrough

Walkthrough

This PR updates ZAPAROO_FORK.md to clarify the Zaparoo launcher feature map and implementation details. The change-map is expanded to separately document launcher pages, H/V offset persistence, OSD auto-dismiss, and CRT-mode-on-exit behavior. Supporting documentation clarifies OSD dismissal ownership and dead code paths, with naming alignment resolved.

Changes

Zaparoo Fork Documentation

Layer / File(s) Summary
Change-map expansion
ZAPAROO_FORK.md
The "System Settings render" cluster is split: right-side display page becomes launcher pages (MENU_ZAPAROO_LAUNCHER* and MENU_ZAPAROO_VIDEO*) plus separate entry for persisted H/V offset; spawn-time OSD auto-dismiss and CRT-mode-on-exit safety entries are added; related entries are renumbered.
Behavioral documentation
ZAPAROO_FORK.md
Two OSD dismissal paths are documented: spawn-side MenuHide() vs F12-menu-side forced dismissal. CRT-mode-on-exit behavior clarified: leaving launcher in CRT mode drops back to HDMI for the session, with preference persisted unchanged.
Symbol alignment and cleanup notes
ZAPAROO_FORK.md
"Naming drift" note resolved to confirm right-side surface uses MENU_ZAPAROO_LAUNCHER* and MENU_ZAPAROO_VIDEO* with renderers in support/zaparoo/launcher_pages.{cpp,h}. alt_launcher_translate_system_select() -1 return and MENU_SYSTEM2 dispatch path documented as unreachable.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • ZaparooProject/Main_MiSTer#2: Implements the alt_launcher CRT toggle and menu/launcher behavior changes that this documentation update describes and clarifies.
  • ZaparooProject/Main_MiSTer#1: Initial Zaparoo launcher integration that established the baseline features now documented in this update.

Poem

A rabbit hops through docs so clear,
Launcher pages, modes sincere—
Dead code marked, alignment found,
CRT drops back to HDMI ground! 🐰✨

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/zaparoo-fb-toggle

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@asturur asturur merged commit 7c6710f into master May 10, 2026
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant