-
Notifications
You must be signed in to change notification settings - Fork 278
fix: 恢复全局快捷键自动复制触发限制 #530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lzx8589561
merged 1 commit into
ZToolsCenter:main
from
Particaly:fix/global-shortcut-auto-copy-guard
Jun 7, 2026
Merged
fix: 恢复全局快捷键自动复制触发限制 #530
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
在
waitForModifierKeysReleased方法中,wrappedResolve在setTimeout的回调函数中被引用,但它的声明(const wrappedResolve = ...)却在setTimeout调用之后。虽然在运行时因为setTimeout是异步执行的,所以不会导致 Temporal Dead Zone (TDZ) 报错,但这种“在声明前引用”的代码结构不符合词法作用域的最佳实践,并且容易触发静态代码分析工具或 Linter(如no-use-before-define)的警告。\n\n建议通过先声明timer,再声明wrappedResolve,最后为timer赋值的方式,优雅地解决这个循环引用的问题。