Fix adjacent Open question gaps rendering as one field#36
Open
pralad-p wants to merge 1 commit into
Open
Conversation
When multiple gap words are next to each other (e.g. `_word1_ _word2_`), the spaces between them were dropped, making them appear and behave as one continuous input field. This was caused by `wrapStringWithPadding` treating whitespace-only strings the same as empty strings. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Owner
|
Thanks, I will have a look! Any reason you closed the PR? |
Author
|
Thanks @Yvee1, ah my bad, I saw the last commit of this project to be 2 years ago, so I assumed it wasn't being actively maintained. Reopened it now. |
Author
|
Je kunt dit als testcase proberen: Zonder deze patch wordt “veiligheid bent” als één woord geïnterpreteerd. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_word1_ _word2_), the spaces between them were being dropped during renderingwrapStringWithPaddingDisclamer
I actually don't know a lot of Haskell (high exaggeration) so this was vibecoded, but just noticed this issue between adjacent
_-padded (Open answers). Feel free to suggest another way to implement this, but just wanted to bring this to your attention. Love the app 🤗