auto-import latest offsets from github - #44
Open
chisewaguri wants to merge 7 commits into
Open
Conversation
chisewaguri
force-pushed
the
offsets-auto-import
branch
from
August 18, 2026 13:12
c6b896d to
0a763fd
Compare
chisewaguri
marked this pull request as draft
August 19, 2026 09:01
chisewaguri
force-pushed
the
offsets-auto-import
branch
from
August 19, 2026 09:07
0a763fd to
dc61a6a
Compare
chisewaguri
marked this pull request as ready for review
August 19, 2026 09:08
Contributor
Author
|
i think this is ready |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Suppressed comments (2)
app/src/main/java/com/ghostlock/app/MainActivity.java:411
- The downloaded table is mutable, unsigned content from
main, yet these values are later trusted as kernel addresses by the native exploit. This bypasses APK signing: a compromised repository credential or unauthorized push could change behavior for installed apps immediately and cause attacker-directed kernel-memory access or crashes. Require a detached signature made by a trusted key and verify it with a public key pinned in the app before merging (or distribute updates through the signed APK/release channel).
conn = (HttpURLConnection) new URL(OFFSETS_URL).openConnection();
tools/gen_offsets_json.py:32
- The parser regex accepts negative hexadecimal literals, but this branch only recognizes strings beginning directly with
0x;-0x2falls through to decimal parsing and raisesValueError, aborting regeneration. Handle the optional sign consistently.
def parse_val(v):
v = v.strip()
if v.startswith("0x") or v.startswith("0X"):
return int(v, 16)
return int(v)
Comment on lines
+434
to
+435
| File offsets = new File(getFilesDir(), OFFSETS_JSON); | ||
| mergeAndSave(offsets, existing, imported, false); |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
chisewaguri
marked this pull request as draft
August 21, 2026 14:31
chisewaguri
force-pushed
the
offsets-auto-import
branch
2 times, most recently
from
August 23, 2026 06:52
578e617 to
d5e1e03
Compare
chisewaguri
force-pushed
the
offsets-auto-import
branch
from
August 23, 2026 07:30
d5e1e03 to
a291b0f
Compare
chisewaguri
marked this pull request as ready for review
August 23, 2026 07:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
offsets.jsonat repo root with all 23 known kernels (generated fromsrc/kernels/*/offsets.h)offsets.jsonwheneversrc/kernels/changes and auto-commits the result