Skip to content

refactor(progressSteps): improve progress steps implementation #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
github-actions wants to merge 1 commit into from
Closed

refactor(progressSteps): improve progress steps implementation #633

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 42 additions & 9 deletions src/github/runAction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,14 +133,32 @@ interface ActionRunContext {
changedFiles?: ChangedFiles;
}

function getProgressSteps(createIssues: boolean): string[] {
if (createIssues) {
return [
'🔍 Gather context',
'🧠 Generate feature plan',
'📌 Create issues',
'🏁 Wrap up',
];
}

return [
'🔍 Gather context',
'✨ Apply edits',
'🧪 Review changes',
'🏁 Wrap up',
];
}

function createRunContext(
config: ActionConfig,
processedEvent: ProcessedEvent,
): ActionRunContext {
return {
config,
processedEvent,
progressSteps: ['🔍 Gather context', '📝 Plan', '✨ Apply edits', '🏁 Wrap up'],
progressSteps: getProgressSteps(processedEvent.createIssues),
downloadedImageFiles: [],
};
}
Expand Down Expand Up @@ -241,6 +259,22 @@ async function executeAction(runCtx: ActionRunContext): Promise<ActionPhaseResul
runCtx.output,
runCtx.progressCommentId,
);
await safeUpdateProgress(
octokit,
repo,
agentEvent.github,
runCtx.progressCommentId,
progressSteps,
2,
);
await safeUpdateProgress(
octokit,
repo,
agentEvent.github,
runCtx.progressCommentId,
progressSteps,
3,
);
return 'success';
}

Expand All @@ -256,6 +290,13 @@ async function executeAction(runCtx: ActionRunContext): Promise<ActionPhaseResul
progressSteps,
2,
);
await handleResult(
config,
processedEvent,
runCtx.output,
runCtx.changedFiles,
runCtx.progressCommentId,
);
await safeUpdateProgress(
octokit,
repo,
Expand All @@ -265,14 +306,6 @@ async function executeAction(runCtx: ActionRunContext): Promise<ActionPhaseResul
3,
);

await handleResult(
config,
processedEvent,
runCtx.output,
runCtx.changedFiles,
runCtx.progressCommentId,
);

return 'success';
}

Expand Down